Skip to content

Comments

Allow dcp interchange to scanout interchange compressed#449

Open
oliverbestmann wants to merge 1 commit intoAsahiLinux:asahi-wipfrom
oliverbestmann:asahi-dcp-interchange
Open

Allow dcp interchange to scanout interchange compressed#449
oliverbestmann wants to merge 1 commit intoAsahiLinux:asahi-wipfrom
oliverbestmann:asahi-dcp-interchange

Conversation

@oliverbestmann
Copy link

@oliverbestmann oliverbestmann commented Feb 7, 2026

Conan-Kudo
Conan-Kudo requested changes Feb 7, 2026
View reviewed changes
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UAPI change needs to be separately contributed to Linux directly, not this fork.

See this documentation: https://docs.kernel.org/process/submitting-patches.html

jannau
jannau reviewed Feb 7, 2026
View reviewed changes
include/uapi/drm/drm_fourcc.h Outdated
*/
#define DRM_FORMAT_MOD_APPLE_GPU_TILED fourcc_mod_code(APPLE, 1)
#define DRM_FORMAT_MOD_APPLE_GPU_TILED_COMPRESSED fourcc_mod_code(APPLE, 2)
#define DRM_FORMAT_MOD_APPLE_INTERCHANGE_COMPRESSED fourcc_mod_code(APPLE, 3)
Copy link
Member

@jannau jannau Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For experimenting we should move this into the driver with

#ifndef DRM_FORMAT_MOD_APPLE_INTERCHANGE_COMPRESSED
#define DRM_FORMAT_MOD_APPLE_INTERCHANGE_COMPRESSED fourcc_mod_code(APPLE, 3)
#endif

I'm not sure if we want one or more APPLE_INTERCHANGE_COMPRESSED modifiers to handle YCbCr formats which use 32x32 tiles for Y

Copy link
Member

@chadmed chadmed Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough of a difference to warrant a new format modifier? If the tile size only changes for the luma channel of Y'CbCr textures, can we not just handle that by checking is_yuv for the framebuffer format info struct? E.g.

tile_w = fb->format->is_yuv ? 32 : 16

@jannau jannau force-pushed the asahi-wip branch 2 times, most recently from 0031cb6 to 79a307d Compare February 14, 2026 20:09
@waltmck
Copy link

waltmck commented Feb 23, 2026 •
edited
Loading

Thank you for the exciting work!

I tested this with nixos-apple-silicon 6.10 using your flake, on an M2 Macbook Air. Hyprland fails to launch with the following repeated log message:

kernel: apple-dcp 231c00000.dcp: swap failed! status 4
kernel: dcp: plane 0 modifiers: c00000000000003
kernel: apple-dcp 231c00000.dcp: RTKit: syslog message: UPPipe.cpp:3920: IOMFB verify_uc_surface: Planesize insufficient for data plane size 17039360, data size 17301504
kernel: apple-dcp 231c00000.dcp: RTKit: syslog message: UPPipeDCP_H13P.cpp:4554: bool IOMFB::UPPipeDCP_H13P::verify_surfaces(IOMFB::SwapRequest *): Error with the interchange surface
kernel: apple-dcp 231c00000.dcp: RTKit: syslog message: FramebufferDCP.cpp:2175: AppleCLCD: verify_swap failed for swap id: 4285

@oliverbestmann oliverbestmann force-pushed the asahi-dcp-interchange branch 2 times, most recently from e9b3b31 to 368641c Compare February 24, 2026 10:50
@oliverbestmann
drm/apple: support interchange compression
cdeaea6 
Signed-off-by: Oliver Bestmann <oliver.bestmann@googlemail.com>
@oliverbestmann
Copy link
Author

oliverbestmann commented Feb 24, 2026

@waltmck

I tested this with nixos-apple-silicon 6.10 using your flake, on an M2 Macbook Air.

Thank you. Is that with the notch enabled or disabled? And what's your selected display resolution?

It was not working with hyprland on my machine too. I've fixed the issue now. Please try again with the latest update to the flake.

@waltmck
Copy link

waltmck commented Feb 25, 2026

@waltmck

I tested this with nixos-apple-silicon 6.10 using your flake, on an M2 Macbook Air.

Thank you. Is that with the notch enabled or disabled? And what's your selected display resolution?

It was not working with hyprland on my machine too. I've fixed the issue now. Please try again with the latest update to the flake.

With your latest flake I can run Hyprland (and I've been using it to work for the last few hours without issues). Is there an easy way to check with certainty that compressed scanout is actually being used?

@oliverbestmann
Copy link
Author

oliverbestmann commented Feb 25, 2026

You can use drm_info to see that modifier c00000000000003 is used for the plane.

@waltmck
Copy link

waltmck commented Feb 25, 2026

You can use drm_info to see that modifier c00000000000003 is used for the plane.

yep, I do see that so it seems to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jannau jannau jannau left review comments

@chadmed chadmed chadmed left review comments

@Conan-Kudo Conan-Kudo Conan-Kudo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oliverbestmann @waltmck @Conan-Kudo @jannau @chadmed